gsmiller commented on PR #12089:
URL: https://github.com/apache/lucene/pull/12089#issuecomment-1408607273

   > I wonder for both these DV-queries (existing one in sandbox and new one 
here in sandbox), if they should really be using this LongBitSet to mark the 
matching ordinals found in the terms dict... it seems overkill/wasteful to 
create a bitset sized over the entire terms dictionary.
   
   Interesting. I'll experiment with that in this benchmark to see if it makes 
any real difference (+1 to being more memory efficient here if possible).
   
   > also personally i wouldn't target the sandbox at all when attacking this 
problem
   
   That's fair. I'll target "non sandbox."
   
   
   I'll work on tightening up the code a bit and adding testing soon.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to