benwtrent commented on PR #12064: URL: https://github.com/apache/lucene/pull/12064#issuecomment-1371336800
@jpountz > One thing I'd like to see is whether we can avoid making AbstractVectorValues public and duplicate logic for byte and float vector values in e.g. VectorScorer and CheckIndex. I can see about that. The downside is that internally, when writing the vectors, having a known `binaryValue` really simplifies things. I will see if I can get the same simplifications in another way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
