vigyasharma commented on PR #11875: URL: https://github.com/apache/lucene/pull/11875#issuecomment-1295741599
> but I'd prefer not to make other implementation details like the custom bulk scorer public, why do you need this? I think they want to use they want to wrap their custom BulkScorer inside the `TimeLimitingBulkScorer`, and need access to it inside their overridden `IndexSearcher.search(...)` method. That would let them move away from their current [CancellableBulkScorer](https://github.com/opensearch-project/OpenSearch/blob/171d14153c8542f25b52428863f1ec9372efd671/server/src/main/java/org/opensearch/search/internal/CancellableBulkScorer.java#L48) impl. Since they override the search() method, their BulkScorer does not get wrapped automatically. To me, it seems like `TimeLimitingBulkScorer` specifically, might be a useful class to expose outside lucene. @jpountz - can you elaborate more on the downsides of exposing this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
