reta commented on PR #11875: URL: https://github.com/apache/lucene/pull/11875#issuecomment-1291944060
Thanks @jpountz > Adding a getter works for me, :+1: > but I'd prefer not to make other implementation details like the custom bulk scorer public, why do you need this? We do override `IndexSearcher::search` [1] and basically take care of `BulkScorer` creation, at this point we could not wrap it up with time limiting one. The TimeLimitingBulkScorer is essentially a simple wrapper, to me there is nothing trully implementation specific / intrisic here (obviusly subjective opionion). Check for example TimeLimitingCollector / TimeLimitingCollector.TimeExceededException pair as an argument towards opening the bulk scorer, it is public API. [1] https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/search/internal/ContextIndexSearcher.java#L276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
