dweiss commented on code in PR #11882: URL: https://github.com/apache/lucene/pull/11882#discussion_r1006457852
########## lucene/build.gradle: ########## @@ -15,6 +15,8 @@ * limitations under the License. */ +apply plugin: 'java' Review Comment: I don't know what that aggregate report task is doing but I would not apply the java plugin to the lucene module. Applying a plugin can mean a lot of other things will trigger automatically on that module - including things like validation, etc. I don't think we want that. I'm not familiar with jacoco (or this task) but it seems it should be possible to aggregate just a selected set of projects, like shown here, for example: https://docs.gradle.org/7.4/samples/sample_jvm_multi_project_with_test_aggregation_standalone.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
