jtibshirani commented on PR #11756: URL: https://github.com/apache/lucene/pull/11756#issuecomment-1238843697
This cuts down on the API surface area for LeafReader results in less logic. I think what we tried to do initially was to push the exhaustive search down to the codec level, so that KnnVectorQuery doesn't need to know about the encoding. However, the VectorEncoding is already public, so it doesn't seem too bad for KnnVectorQuery to consider it (especially since it's abstracted away into VectorScorer). If we want to limit knowledge of the encoding outside each codec, I think we should focus on removing VectorValues#binaryValue altogether, which would require a different refactoring approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
