yugushihuang commented on PR #1057: URL: https://github.com/apache/lucene/pull/1057#issuecomment-1208231388
> The idea seems good - we want to track merge times separately for each format, right? I wonder if the Filter classes belong in a monitoring package though. It's also a confusing name since we already have a `monitor` package which is something completely different. Perhaps a better place for the `Filter*` classes would be `org.apache.lucene.codecs.filter` (in `core` module), and then we could put the `MergeTimeTrackingCodec` in the `sandbox` module somewhere? Maybe in `o.a.l.sandbox.metrics`? (to avoid confusion with monitor) Yes, it use to track merge time for each format. Thanks for the suggestion, I will make revision accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
