gsmiller commented on code in PR #1062:
URL: https://github.com/apache/lucene/pull/1062#discussion_r950251125
##########
lucene/core/src/java/org/apache/lucene/search/TermInSetQuery.java:
##########
@@ -293,6 +296,9 @@ private WeightOrDocIdSet rewrite(LeafReaderContext context)
throws IOException {
builder.add(docs);
Review Comment:
@LuXugang I'm not sure I follow your question. `builder.add(docs)` will add
all docs for the term's `PostingsEnum` to the `DocIdSetBuilder`. Or are you
referring to the initialization of the builder here: `builder = new
DocIdSetBuilder(reader.maxDoc(), terms);`? In this initialization,
`reader.maxDoc()` is used to specify the number of possible docids (used to
size the underlying bitset). `reader.maxDoc()` returns "one greater than the
largest possible document number" (according to javadoc), so this should be
correct.
Sorry if I'm misunderstanding your question.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
