LuXugang commented on code in PR #1021:
URL: https://github.com/apache/lucene/pull/1021#discussion_r921847372
##########
lucene/core/src/java/org/apache/lucene/index/SortedSetDocValuesWriter.java:
##########
@@ -391,11 +386,7 @@ public boolean advanceExact(int target) throws IOException
{
@Override
public long nextOrd() {
- if (limit == ordUpto) {
- return NO_MORE_ORDS;
- } else {
- return ords.ords.get(ordUpto++);
- }
+ return ords.ords.get(ordUpto++);
Review Comment:
Hi @gsmiller ,I saw `limit` was removed, did you mean Caller should take the
responsibility to check whether `nextOrd()` is out of bound by
`docValueCount()`?
In `SortingSortedNumericDocValues`, there is also a `limit` used to throw
exception if `nextValue()` is out of bound. should we keep the same logic
between them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
