jpountz commented on PR #907:
URL: https://github.com/apache/lucene/pull/907#issuecomment-1181518177

   @shahrs87 Can you look into removing all other instances of `terms == 
Terms.EMPTY` or `terms != Terms.EMPTY` as well? To do this while keeping tests 
passing, I think you'll need to create empty `Terms` instances that still honor 
the options of the `FieldInfo` as per my previous suggestion. E.g. you could 
add a new `Terms#empty(FieldInfo)` helper method that does the right thing for 
`hasFreqs()`, `hasPositions()`, etc. by looking at the index options of the 
`FieldInfo`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to