shahrs87 commented on code in PR #907:
URL: https://github.com/apache/lucene/pull/907#discussion_r905561688


##########
lucene/core/src/java/org/apache/lucene/index/FrozenBufferedUpdates.java:
##########
@@ -595,7 +595,7 @@ private void setField(String field) throws IOException {
 
     DocIdSetIterator nextTerm(String field, BytesRef term) throws IOException {
       setField(field);
-      if (termsEnum != null) {
+      if (termsEnum != null && termsEnum != TermsEnum.EMPTY) {

Review Comment:
   The following test failed 
`TestPointQueries#testAllPointDocsWereDeletedAndThenMergedAgain`
   ```
   Cannot read field "bytes" because "other" is null
   java.lang.NullPointerException: Cannot read field "bytes" because "other" is 
null
        at 
__randomizedtesting.SeedInfo.seed([16B9FF96CE2E2AF5:59A84BA7E3282B90]:0)
        at org.apache.lucene.util.BytesRef.compareTo(BytesRef.java:159)
        at 
org.apache.lucene.index.FrozenBufferedUpdates$TermDocsIterator.nextTerm(FrozenBufferedUpdates.java:604)
        at 
org.apache.lucene.index.FrozenBufferedUpdates.applyTermDeletes(FrozenBufferedUpdates.java:473)
        at 
org.apache.lucene.index.FrozenBufferedUpdates.apply(FrozenBufferedUpdates.java:175)
        at org.apache.lucene.index.IndexWriter.forceApply(IndexWriter.java:5965)
        at org.apache.lucene.index.IndexWriter.tryApply(IndexWriter.java:5865)
        at 
org.apache.lucene.index.IndexWriter.lambda$publishFrozenUpdates$10(IndexWriter.java:2771)
        at 
org.apache.lucene.index.IndexWriter$EventQueue.processEventsInternal(IndexWriter.java:328)
        at 
org.apache.lucene.index.IndexWriter$EventQueue.processEvents(IndexWriter.java:317)
        at 
org.apache.lucene.index.IndexWriter.processEvents(IndexWriter.java:5708)
        at org.apache.lucene.index.IndexWriter.doFlush(IndexWriter.java:4038)
        at org.apache.lucene.index.IndexWriter.flush(IndexWriter.java:3995)
        at org.apache.lucene.index.IndexWriter.forceMerge(IndexWriter.java:2099)
        at org.apache.lucene.index.IndexWriter.forceMerge(IndexWriter.java:2080)
        at 
org.apache.lucene.search.TestPointQueries.testAllPointDocsWereDeletedAndThenMergedAgain(TestPointQueries.java:1221)
        at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
        at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:568)
        at 
com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1754)
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to