mayya-sharipova commented on code in PR #947:
URL: https://github.com/apache/lucene/pull/947#discussion_r897925136
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene93/OffHeapVectorValues.java:
##########
@@ -41,11 +42,11 @@ abstract class OffHeapVectorValues extends VectorValues
protected final int byteSize;
protected final float[] value;
- OffHeapVectorValues(int dimension, int size, IndexInput slice) {
+ OffHeapVectorValues(int dimension, int size, IndexInput slice, int byteSize)
{
Review Comment:
For DOT_PRODUCT8 case for `vectorValue(..)` functions should we use
`slice.readBytes` instead of `slice.ReadFloats` and then convert them to
floats? Otherwise, it looks to me we are reading wrong values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
