mocobeta commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873972923
##########
lucene/distribution.tests/src/test/org/apache/lucene/distribution/AbstractLuceneDistributionTest.java:
##########
@@ -47,6 +52,19 @@ public abstract class AbstractLuceneDistributionTest extends
RandomizedTest {
/** Resolved and validated {@link #DISTRIBUTION_PROPERTY}. */
private static Path distributionPath;
+ // --------------------------------------------------------------------
+ // Test groups, system properties and other annotations modifying tests
+ // --------------------------------------------------------------------
+
+ public static final String SYSPROP_NIGHTLY = "tests.nightly";
+
+ /** Annotation for tests that should only be run during nightly builds. */
+ @Documented
+ @Inherited
+ @Retention(RetentionPolicy.RUNTIME)
+ @TestGroup(enabled = false, sysProperty = SYSPROP_NIGHTLY)
+ public @interface Nightly {}
Review Comment:
@dweiss I renamed the annotation (test group) as suggested, added
`tests.gui` system property for the test group, and made the sysprop forcibly
set to true on CI builds - does this change make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
