dweiss commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873730908
##########
lucene/distribution.tests/src/test/org/apache/lucene/distribution/AbstractLuceneDistributionTest.java:
##########
@@ -47,6 +52,19 @@ public abstract class AbstractLuceneDistributionTest extends
RandomizedTest {
/** Resolved and validated {@link #DISTRIBUTION_PROPERTY}. */
private static Path distributionPath;
+ // --------------------------------------------------------------------
+ // Test groups, system properties and other annotations modifying tests
+ // --------------------------------------------------------------------
+
+ public static final String SYSPROP_NIGHTLY = "tests.nightly";
+
+ /** Annotation for tests that should only be run during nightly builds. */
+ @Documented
+ @Inherited
+ @Retention(RetentionPolicy.RUNTIME)
+ @TestGroup(enabled = false, sysProperty = SYSPROP_NIGHTLY)
+ public @interface Nightly {}
Review Comment:
Thanks for cleaning up those workflow files, @mocobeta ! I don't haven that
much experience with github actions so it's definitely cruft that accumulated
over time.
Adding a new test group itself (disabled by default) doesn't require any
special actions. If we want to run it on nightly runs then yes - jenkins would
have to be configured properly for this... Alternatively, the value of the
property triggering the test group could be computed inside gradle scripts
(much like Uwe recently modified the errorprone to run on CI servers). Does
this sound better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
