[
https://issues.apache.org/jira/browse/LUCENE-10488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536968#comment-17536968
]
Yuting Gan commented on LUCENE-10488:
-------------------------------------
Thank you so much for reviewing and merging my PRs! I will work on adding
getTopDim to benchmarks soon.
> Optimize Facets#getTopDims across Facets implementations
> --------------------------------------------------------
>
> Key: LUCENE-10488
> URL: https://issues.apache.org/jira/browse/LUCENE-10488
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
> Reporter: Greg Miller
> Priority: Minor
> Fix For: 9.2
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> LUCENE-10325 added a new {{getTopDims}} API, allowing users to specify the
> number of "top" dimensions they want. The default implementation just
> delegates to {{getAllDims}} and returns the number of top dims requested, but
> some Facets sub-classes can do this more optimally. LUCENE-10325 demonstrated
> this in {{SortedSetDocValueFacetCounts}}, but we can take it further. There's
> at least some opportunity to do better in:
> * {{ConcurrentSortedSetDocValuesFacetCounts}}
> * {{FastTaxonomyFacetCounts}}
> * {{TaxonomyFacetSumFloatAssociations}}
> * {{TaxonomyFacetSumIntAssociations}}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
