[ https://issues.apache.org/jira/browse/LUCENE-10488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17513722#comment-17513722 ]
Greg Miller edited comment on LUCENE-10488 at 3/28/22, 11:41 PM: ----------------------------------------------------------------- Note that I have an [open PR|https://github.com/apache/lucene/pull/719] that proposes some significant changes to association facets, so might be worth trying to avoid large merge collisions with that if someone jumps on this. was (Author: gsmiller): Note that I have an [open PR](https://github.com/apache/lucene/pull/719) that proposes some significant changes to association facets, so might be worth trying to avoid large merge collisions with that if someone jumps on this. > Optimize Facets#getTopDims across Facets implementations > -------------------------------------------------------- > > Key: LUCENE-10488 > URL: https://issues.apache.org/jira/browse/LUCENE-10488 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/facet > Reporter: Greg Miller > Priority: Minor > > LUCENE-10325 added a new {{getTopDims}} API, allowing users to specify the > number of "top" dimensions they want. The default implementation just > delegates to {{getAllDims}} and returns the number of top dims requested, but > some Facets sub-classes can do this more optimally. LUCENE-10325 demonstrated > this in {{SortedSetDocValueFacetCounts}}, but we can take it further. There's > at least some opportunity to do better in: > * {{ConcurrentSortedSetDocValuesFacetCounts}} > * {{FastTaxonomyFacetCounts}} > * {{TaxonomyFacetSumFloatAssociations}} > * {{TaxonomyFacetSumIntAssociations}} -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org