gsmiller commented on PR #777: URL: https://github.com/apache/lucene/pull/777#issuecomment-1122652678
> just an observation, this is a large amount of code changes for performance change that may be in the noise? I'm a bit confused. I don't think we actually have benchmarks for this functionality yet. A little while back, @Yuti-G added new functionality for `getTopDims` ([LUCENE-10325](https://issues.apache.org/jira/browse/LUCENE-10325))that, by default, just delegates to `getAllDims` and truncates. This is an attempt to make `getTopDims` more efficient, but I think we're missing benchmarks to actually measure that. Is that accurate @Yuti-G, or did you add some new benchmarks that I'm unaware of? Maybe I'm missing that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
