[
https://issues.apache.org/jira/browse/LUCENE-10538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534019#comment-17534019
]
Yuting Gan commented on LUCENE-10538:
-------------------------------------
Yes, thanks [~gsmiller]! I am working on LUCENE-10550 and should have a PR out
soon, and then I will re-visit this issue and return real top-n children.
> TopN is not being used in getTopChildren()
> ------------------------------------------
>
> Key: LUCENE-10538
> URL: https://issues.apache.org/jira/browse/LUCENE-10538
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/facet
> Reporter: Yuting Gan
> Priority: Minor
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> When looking at the overridden implementation getTopChildren(int topN, String
> dim, String... path) in RangeFacetCounts, I found that the topN parameter is
> not being used in the code, and the unit tests did not test this function
> properly. I will create a PR to fix this, and will look into other overridden
> implementations and see if they have the same issue. Please let me know if
> there is any question. Thanks!
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
