[
https://issues.apache.org/jira/browse/LUCENE-10538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17533912#comment-17533912
]
Greg Miller commented on LUCENE-10538:
--------------------------------------
So I think the order of operations here is:
1. Deliver [LUCENE-10550|https://issues.apache.org/jira/browse/LUCENE-10550],
which would effectively _copy_ the currently "top children" functionality of
range faceting to a new API method for getting all children (which is what it's
really doing).
2. Fix the existing "top children" functionality of range faceting to actually
return top children (and honor the top-n parameter).
I think this issue now effectively captures #2, and is blocked until
LUCENE-10550 is delivered. Does that sound right [~yutinggan]?
> TopN is not being used in getTopChildren()
> ------------------------------------------
>
> Key: LUCENE-10538
> URL: https://issues.apache.org/jira/browse/LUCENE-10538
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/facet
> Reporter: Yuting Gan
> Priority: Minor
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> When looking at the overridden implementation getTopChildren(int topN, String
> dim, String... path) in RangeFacetCounts, I found that the topN parameter is
> not being used in the code, and the unit tests did not test this function
> properly. I will create a PR to fix this, and will look into other overridden
> implementations and see if they have the same issue. Please let me know if
> there is any question. Thanks!
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
