mikemccand commented on code in PR #858: URL: https://github.com/apache/lucene/pull/858#discussion_r862869056
########## lucene/core/src/java/org/apache/lucene/util/compress/LowercaseAsciiCompression.java: ########## @@ -111,14 +111,13 @@ public static boolean compress(byte[] in, int len, byte[] tmp, DataOutput out) numExceptions2++; } } + + // TODO: shouldn't this really be an assert instead? but then this real "if" triggered + // LUCENE-10551 so maybe it should remain a real "if": Review Comment: https://github.com/apache/lucene/pull/861 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org