LuXugang commented on PR #792: URL: https://github.com/apache/lucene/pull/792#issuecomment-1114014473
> I've left a couple of comments, but I am also wondering what is the reason you deleted `TestBackwardsCompatibility.java` in this PR? Hi @mayya-sharipova , since `9.1.0-cfs` and `9.1.0-nocfs` were added from https://github.com/apache/lucene/commit/04127ed9fc6972bb3d6ab5aed86c3512b2971aba which based on `Lucene91HnswVectorsFormat`, and changes in RP still work on `Lucene91HnswVectorsFormat`, so TestBackwardsCompatibility will not pass. After renaming modified `Lucene91HnswVectorsXXX` to `Lucene92HnswVectorsXXX` , deleted TestBackwardsCompatibility could be reverted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
