vigyasharma commented on code in PR #633:
URL: https://github.com/apache/lucene/pull/633#discussion_r862140049
##########
lucene/core/src/test/org/apache/lucene/index/TestAddIndexes.java:
##########
@@ -1014,8 +1304,6 @@ public void testAddIndexesWithRollback() throws Throwable
{
}
c.closeDir();
-
- assertTrue(c.failures.size() == 0);
Review Comment:
We don't. This checks for failures when writer.close() was called. We are
able to abort merges and don't have any failures, so this assertion is valid. I
think I removed it while debugging some breaking tests and missed adding it
back. Added it back now. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
