iverase commented on PR #756:
URL: https://github.com/apache/lucene/pull/756#issuecomment-1108472913

   Hi @yixunx,
   
   I had a look to the polygon and it seems to be a totally different type of 
error and I would prefer to handle it as a separate issue. In the meanwhile I 
propose to push this change as it is as it contains good fixes for the other 
cases, what do you think?
   
   >By the way I have a tangential question: the Tessellator javadoc says the 
polygon cannot have self-intersections, but it seems that the tessellator runs 
fine on shapes with self intersections unless I set checkSelfIntersections = 
true
   
   I was not the original contributor for this class so I cannot answer that 
question on the javadocs and I have always found estrange that javadocs says 
that polygons should not have self-intersections and then we have a method 
called `cureLocalIntersections` which it seems to expect self-intersections 
(currently this method never gets exercise on the test and I am always 
considering if it should be removed).  I wonder if this method is making your 
polygons to succeed.
   
   I would porpoase to open another issue with this subject so we can capture 
the intention of the javadocs and see if we should take any action.
   
     
   
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to