JarvisCraft opened a new pull request, #830:
URL: https://github.com/apache/lucene/pull/830
# Description
This PR adds a `lucene-bom` to list other Lucene modules in its
`dependencyManagement` POM segment.
This allows external projects to only specify BOM-module's version while
listing other modules (such as `lucene-core`) without version specification.
# Solution
This PR consists of the following parts:
- `lucene-bom` module:
- added to `lucene/` directory
- listed in `settings.gradle`
- configured to list all dependencies (except for itself) as API
dependencies (translates to `dependencyManagement.dependencies` in Maven POM)
- configured custom `publishing` name (`bom`) and `from` sub-section
- reworked current publishing configurations to:
- add metadata to BOM module too
- always publish BOM (via corresponding
`publishBomPublicationTo${repository}Repository` tasks)
# Tests
Automatic tests are not applicable to this PR as it implements changes to
the build system itself.
However it was tested locally using `./gradlew mavenToLocal` to make sure
that it produces correct Maven artifacts.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to
Contribute](https://github.com/apache/lucene/blob/main/CONTRIBUTING.md) and my
code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request
title.
- [x] I have given Lucene maintainers
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [x] ~~I have added tests for my changes.~~ N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
