gautamworah96 commented on code in PR #762: URL: https://github.com/apache/lucene/pull/762#discussion_r844502429
########## lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/AlwaysRefreshDirectoryTaxonomyReader.java: ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.facet.taxonomy.directory; + +import java.io.IOException; +import org.apache.lucene.index.DirectoryReader; +import org.apache.lucene.store.Directory; +import org.apache.lucene.util.IOUtils; + +/** + * A modified DirectoryTaxonomyReader that always recreates a new {@link + * AlwaysRefreshDirectoryTaxonomyReader} instance when {@link + * AlwaysRefreshDirectoryTaxonomyReader#doOpenIfChanged()} is called. This enables us to easily go + * forward or backward in time by re-computing the ordinal space during each refresh. Review Comment: ++ I separated it to a different class because in an earlier [comment](https://github.com/apache/lucene/pull/762#discussion_r840008690) we thought that it could be a good idea to directly expose it to our users. Let's keep it as a test class for now. We can explore the idea of making `DTR smarter to detect when a "roll backwards / revert" situation` in another issue (we will also have to think about how to handle older indexes etc). One thing at a time.. I'll revert it back to a test class -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
