gsmiller commented on a change in pull request #747:
URL: https://github.com/apache/lucene/pull/747#discussion_r832488053
##########
File path:
lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesFacetCounts.java
##########
@@ -178,10 +229,23 @@ private FacetResult getPathResult(
}
}
- if (q == null) {
- return null;
+ if (dimConfig.hierarchical == false) {
Review comment:
I'm not sure all the cases are covered. What about `getTopChildren`? It
looks like it could call `getPathResult` for a hierarchical + multivalued case.
Maybe I'm just missing something?
But either way, I'd prefer `getChildOrdsResult` not rely on the specific
ways it gets called today. If it's providing correct counts, it should do so in
all cases. Or alternatively, you could state that it's invalid to use that
method for the hierarchical + multivalued case and put an assert in to ensure
that's true (but it seems like it will need to be called for that case). Does
this make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
