Yuti-G opened a new pull request #751: URL: https://github.com/apache/lucene/pull/751
# Description Currently, there are different behaviors from subclass that implements `getAllDims` and `getTopChildren` when the requested `topN` is invalid (`topN <= 0`). Some overridden implementations throw a `NullPointerException` and others throw an `IllegalArgumentException`. This change aligns the behaviors across all overridden implementations of `getAllDims` and `getTopChildren` by throwing an `IllegalArgumentException` and exiting the function earlier if the parameter `topN` is invalid. # Solution Added a condition checking if `topN <= 0` in the beginning of both functions. If `topN` is invalid, the function will be terminated by throwing an `IllegalArgumentException`. # Tests Added new testing, `getAllDims(0)` and `getTopChildren(0, dim)`, for all subclass that implements `getAllDims` and `getTopChildren`. # Checklist Please review the following and check all that apply: - [X] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [X] I have created a Jira issue and added the issue ID to my pull request title. - [X] I have given Lucene maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [X] I have developed this patch against the `main` branch. - [X] I have run `./gradlew check`. - [X] I have added tests for my changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
