[ 
https://issues.apache.org/jira/browse/LUCENE-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yuting Gan updated LUCENE-10467:
--------------------------------
    Description: 
Currently, when calling getAllDims(0) in SortedSetDocValuesFacetCounts, it 
would throw a  NullPointerException. Other class that implements the getAllDims 
functionality could have the same issue, except for TaxonomyFacetCounts, which 
has been tested. 

It would provide better user experience by throwing an IllegalArgumentException 
when requesting topN <= 0 for getAllDims.

  was:
Currently, when calling getAllDims(0) in SortedSetDocValuesFacetCounts, it 
would throw a  NullPointerException. Other class that implements the getAllDims 
functionality could have the same issue, except for TaxonomyFacetCounts, which 
has been tested. 

It would provide better user experience by throwing an IllegalArgumentException 
when requesting topN = 0 for getAllDims.


> Throws IllegalArgumentException for getAllDims if topN <= 0
> -----------------------------------------------------------
>
>                 Key: LUCENE-10467
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10467
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/facet
>            Reporter: Yuting Gan
>            Priority: Minor
>
> Currently, when calling getAllDims(0) in SortedSetDocValuesFacetCounts, it 
> would throw a  NullPointerException. Other class that implements the 
> getAllDims functionality could have the same issue, except for 
> TaxonomyFacetCounts, which has been tested. 
> It would provide better user experience by throwing an 
> IllegalArgumentException when requesting topN <= 0 for getAllDims.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to