[
https://issues.apache.org/jira/browse/LUCENE-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506488#comment-17506488
]
Dawid Weiss commented on LUCENE-10461:
--------------------------------------
Just to be clear - I did take a look at the patch... I know what you're trying
to do but something in me says it's not going to work reliably (the timeouts
awaiting the appearance of the log file, the wait for the buffer flush from a
subprocess). I think it's far less trappy to just use the blocking java call in
the script for integration tests...
If you're convinced this is the way to go then I'm not going to stand in the
way... I'd perhaps suggest to at least make the start command blocking (add the
/wait option in the script just for testing) - this will eliminate the need to
wait for the log file to appear (as start will be synchronous then).
> Luke: Windows launch script passes integration tests but fails to run
> ---------------------------------------------------------------------
>
> Key: LUCENE-10461
> URL: https://issues.apache.org/jira/browse/LUCENE-10461
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Major
> Fix For: 9.1, 10.0 (main)
>
> Attachments: image-2022-03-13-11-18-34-704.png
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> PR at https://github.com/apache/lucene/pull/743
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
