[
https://issues.apache.org/jira/browse/LUCENE-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506458#comment-17506458
]
Dawid Weiss commented on LUCENE-10461:
--------------------------------------
Hey, Tomoko. I don't think we should go in the direction you have in your
patch. java and javaw are literally the same, functionally. The difference is
one has a window-application api entry and the other requires console support -
it really doesn't matter from Luke's point of view. I also think it is more
than fine to run the tests with 'java' and skip the 'start' to make the script
blocking. It is a Windows-specific script and it is a Windows-specific
workaround to make the test behave better. With your patch, the test relies on
wall clock to detect the log file and is just more complex than it has to be.
Just my few cents.
> Luke: Windows launch script passes integration tests but fails to run
> ---------------------------------------------------------------------
>
> Key: LUCENE-10461
> URL: https://issues.apache.org/jira/browse/LUCENE-10461
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Major
> Fix For: 9.1, 10.0 (main)
>
> Attachments: image-2022-03-13-11-18-34-704.png
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> PR at https://github.com/apache/lucene/pull/743
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
