javanna commented on a change in pull request #622:
URL: https://github.com/apache/lucene/pull/622#discussion_r791803883
##########
File path:
lucene/misc/src/test/org/apache/lucene/misc/search/TestMemoryAccountingBitsetCollector.java
##########
@@ -64,14 +62,12 @@ public void
testMemoryAccountingBitsetCollectorMemoryLimit() {
CollectorMemoryTracker tracker =
new CollectorMemoryTracker("testMemoryTracker",
perCollectorMemoryLimit);
MemoryAccountingBitsetCollector bitSetCollector = new
MemoryAccountingBitsetCollector(tracker);
- TotalHitCountCollector hitCountCollector = new TotalHitCountCollector();
IndexSearcher searcher = new IndexSearcher(reader);
expectThrows(
IllegalStateException.class,
() -> {
- searcher.search(
- new MatchAllDocsQuery(), MultiCollector.wrap(hitCountCollector,
bitSetCollector));
+ searcher.search(new MatchAllDocsQuery(), bitSetCollector);
Review comment:
here too: two collectors were used, but the total hits were never
retrieved from the total hit count collector. Removing its usage seems ok
according to tests. Is this ok to change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
