javanna commented on a change in pull request #622:
URL: https://github.com/apache/lucene/pull/622#discussion_r791803590
##########
File path:
lucene/misc/src/test/org/apache/lucene/misc/search/TestDocValuesStatsCollector.java
##########
@@ -396,10 +394,8 @@ public void testDocsWithSortedSetValues() throws
IOException {
try (DirectoryReader reader = DirectoryReader.open(indexWriter)) {
IndexSearcher searcher = new IndexSearcher(reader);
SortedSetDocValuesStats stats = new SortedSetDocValuesStats(field);
- TotalHitCountCollector totalHitCount = new TotalHitCountCollector();
- searcher.search(
- new MatchAllDocsQuery(),
- MultiCollector.wrap(totalHitCount, new
DocValuesStatsCollector(stats)));
+
+ searcher.search(new MatchAllDocsQuery(), new
DocValuesStatsCollector(stats));
Review comment:
I am possibly missing something here: two collectors were used, but the
total hits were never retrieved from the total hit count collector. Removing
its usage seems ok according to tests. Is this ok to change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
