gsmiller commented on a change in pull request #600:
URL: https://github.com/apache/lucene/pull/600#discussion_r783300374
##########
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/IntTaxonomyFacets.java
##########
@@ -62,8 +52,82 @@ protected IntTaxonomyFacets(
}
}
+ /** Rolls up any single-valued hierarchical dimensions. */
+ void rollup() throws IOException {
Review comment:
FYI this is not brand new code. The diff is getting a little confused
since I did modify the methods (to directly access the counting data
structures, eliminating the need for `increment`) and I also reorganized the
methods to group pkg-private and private together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
