uschindler commented on a change in pull request #590:
URL: https://github.com/apache/lucene/pull/590#discussion_r780306400



##########
File path: lucene/core/src/test/org/apache/lucene/util/automaton/TestRegExp.java
##########
@@ -99,6 +99,7 @@ private static int randomInt(int bound) {
     return bound == 0 ? 0 : random().nextInt(bound);
   }
 
+  @SuppressWarnings("BareDotMetacharacter")

Review comment:
       I replaced this locally by `".".repeat(replacementPart.length())`, which 
is much more readable than the previous `replaceAll(".", ".")` (new API in Java 
11, very fast for chars). The dot regex alone looks too crazy.
   This is unrelated to forbiddenapis.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to