rmuir commented on a change in pull request #590:
URL: https://github.com/apache/lucene/pull/590#discussion_r780281728



##########
File path: lucene/core/src/test/org/apache/lucene/util/automaton/TestRegExp.java
##########
@@ -99,6 +99,7 @@ private static int randomInt(int bound) {
     return bound == 0 ? 0 : random().nextInt(bound);
   }
 
+  @SuppressWarnings("BareDotMetacharacter")

Review comment:
       could we disable the check and just add String.replaceAll to forbidden 
instead?
   
   I'd really prefer we implement such checks outside of the 
nightly-only-slow-errorprone, if possible. It means less tension between 
builds/failures and developers




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to