ywelsch commented on a change in pull request #539:
URL: https://github.com/apache/lucene/pull/539#discussion_r768409970
##########
File path: lucene/core/src/java/org/apache/lucene/index/SegmentCommitInfo.java
##########
@@ -244,7 +244,9 @@ public long sizeInBytes() throws IOException {
// updates) and then maybe even be able to remove LiveDocsFormat.files().
// Must separately add any live docs files:
- info.getCodec().liveDocsFormat().files(this, files);
+ if (hasDeletions()) {
+ info.getCodec().liveDocsFormat().files(this, files);
Review comment:
This now allows for a minimal codec that does not have a LiveDocsFormat
when no deletes are being used. It was a tiny change to make, but perhaps out
of scope for this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
