jtibshirani commented on a change in pull request #580:
URL: https://github.com/apache/lucene/pull/580#discussion_r777676777
##########
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java
##########
@@ -239,6 +239,9 @@ public TopDocs search(String field, float[] target, int k,
Bits acceptDocs) thro
if (fieldEntry == null || fieldEntry.dimension == 0) {
return null;
}
+ if (fieldEntry.size() == 0) {
Review comment:
Would it be simpler to return null here?
##########
File path:
lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseKnnVectorsFormatTestCase.java
##########
@@ -559,6 +561,12 @@ public void testDeleteAllVectorDocs() throws Exception {
VectorValues values = getOnlyLeafReader(r).getVectorValues("v");
assertNotNull(values);
assertEquals(0, values.size());
+
+ // assert that knn search doesn't fail on a field with all deleted docs
+ IndexSearcher searcher = newSearcher(r);
Review comment:
Small comment, maybe we can use `LeafReader` directly here. That way
this test stays focused on the vectors format instead of `KnnVectorQuery`,
which sometimes adds extra logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
