uschindler commented on pull request #581: URL: https://github.com/apache/lucene/pull/581#issuecomment-1004282413
@rmuir I will move the TestAllAnalyzerHaveFactories test to the same "TestDistribution" in a separate issue. The current test only works with Common Analyzers. Basically it just have to check in same way by iterating over the class files that there's a factory for all tokenizer components. > the org.apache.lucene.analysis.pt stuff is only needed internally. I assume src/java/resources/org/apache/lucene/analysis/compound hypenation.dtd, also only needed internally? Yes, the XML parser uses it internally to verify the file is correct: https://github.com/apache/lucene/blob/main/lucene/analysis/common/src/java/org/apache/lucene/analysis/compound/hyphenation/PatternParser.java#L237-L245 > I checked ICU which also looks good. the .nrm file is "exposed" as ICUFoldingFilter.NORMALIZER constant in case someone needs it. This is the same I did. The brk files should be public, the nrm file is only loaded in static initializer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
