uschindler commented on pull request #579: URL: https://github.com/apache/lucene/pull/579#issuecomment-1004188776
I gave some comments; the deprecated Long ctor should be fixed, so we should open a separate issue. I'd suggest to switch over to Optional instead of a plain Long to signal empty outputs. Or NULL? In general +1 as first step. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
