mocobeta edited a comment on pull request #572: URL: https://github.com/apache/lucene/pull/572#issuecomment-1002103570
I have seen (once or twice) seen `--patch-module` option and wondered what's the use-case... thanks for the detailed explanation. If we can run all tests in module mode (with module patching), it'd be great; but if it makes writing simple unit tests complicated or difficult, personally I am fine with having/maintaining two sets of tests - classpath mode tests (in the same module) for white-box test, and module mode tests for black-box tests (in the separate module). The latter should be just sanity checks if the former is well written, I think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
