uschindler edited a comment on pull request #572: URL: https://github.com/apache/lucene/pull/572#issuecomment-1002078508
> a static require will fail much earlier if these modules are not available - it'll fail during compilation because at compile-time requires static is a hard requirement. So if it compiles, it'll likely pass tests without this explicit clause: > > > "--add-modules", "jdk.unsupported,jdk.management" Yes I know, but if we fix the Gradle test runner at some point in the future, we should at least document this. So let's keep this in, because the gradle runner at the moment makes the modules available implicit -- and I like it explicit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
