dsmiley commented on a change in pull request #2597:
URL: https://github.com/apache/lucene-solr/pull/2597#discussion_r766197049
##########
File path: solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java
##########
@@ -2269,7 +2269,12 @@ public boolean update() throws KeeperException,
InterruptedException {
log.debug("Checking ZK for most up to date Aliases {}", ALIASES);
// Call sync() first to ensure the subsequent read (getData) is up to
date.
zkClient.getSolrZooKeeper().sync(ALIASES, null, null);
- Stat stat = new Stat();
+ Stat stat = zkClient.exists(ALIASES, null, true);
+ if (stat.getVersion() <= aliases.getZNodeVersion()) {
Review comment:
Interesting. So you've found that it's faster to request only the
"Stat" without the data so long as this is the typical path?
##########
File path: solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java
##########
@@ -441,7 +441,10 @@ protected void extractRemotePath(String collectionName,
String origCorename) thr
} else {
if (!retry) {
// we couldn't find a core to work with, try reloading aliases & this
collection
- cores.getZkController().getZkStateReader().aliasesManager.update();
+
if(!cores.getZkController().getZkStateReader().aliasesManager.update()) {
+ //no change. go back
+ return;
Review comment:
what about the line below, forceUpdateCollection?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
