ChrisHegarty commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r766030837



##########
File path: lucene/licenses/asm-analysis-7.2.jar.sha1
##########
@@ -0,0 +1 @@
+b6e6abe057f23630113f4167c34bda7086691258

Review comment:
       Ah, I see it. For better or worse the ASM maintainer(s) (Remi), has 
decided that if you wanna use the asm-commons as a module then you need need 
_tree_ and _tree.analysis_. Despite how the module-info.class gets into 
asm-commons, it is there. Ok I get it.
   
   Options 3 - fake out empty _tree_ and _tree.analysis_ modules, and put them 
on our module path.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to