ChrisHegarty commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r766001739
##########
File path: lucene/licenses/asm-analysis-7.2.jar.sha1
##########
@@ -0,0 +1 @@
+b6e6abe057f23630113f4167c34bda7086691258
Review comment:
@uschindler I've not come across this kind of issue with painless (I'm
just not far enough yet), but I have seen similar with the x-content library.
The x-content library depends upon Jackson-dataformat-yaml, which depends upon
Jackson-databind, but woops we don't have a Gradle dependency on databind,
since it would appear that x-content doesn't use the parts of
Jackson-dataformat-yaml that have static dependencies on databind. This is
really living on the edge! ;-)
Now with modules, Jackson-dataformat-yaml `requires` databind, so you gotta
have it! I took the simple approach at this point, and followed what the
Jackson maintainers thought was appropriate (since they wrote the `requires`
directive), I just added a moduleImplementation dependency no databind.
It's not possible, at least not with command line gymnastics, to augment a
module descriptor to remove a `requires` directive. You could fake it with an
empty synthetic module declaration, but that seems quite hacky.
I wonder how many of these kinda situations will arise? Also, I think you're
case is a little different since it is an automatic module that has the
requires ( whereas in the above case, the Jackson yaml module has a module-info
).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
