iverase commented on a change in pull request #486:
URL: https://github.com/apache/lucene/pull/486#discussion_r762755043
##########
File path: lucene/core/src/java/org/apache/lucene/index/PointValues.java
##########
@@ -361,14 +405,29 @@ private void intersect(IntersectVisitor visitor,
PointTree pointTree) throws IOE
// TODO: we can assert that the first value here in fact matches
what the pointTree
// claimed?
// Leaf node; scan and filter all points in this block:
- pointTree.visitDocValues(visitor);
+ visitor.grow((int) pointTree.size());
Review comment:
Maybe even better would be something like:
```
visitor.grow((int) Math.min(getDocCount(), pointTree.size()))
```
Which agrees with grow() contract as it refers to number of documents not
number of points:
```
/** Notifies the caller that this many documents are about to be visited */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
