gsmiller commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r750715374
##########
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetUtils.java
##########
@@ -81,4 +84,18 @@ public long cost() {
}
};
}
+
+ /**
+ * Determine whether-or-not an index segment is using the older-style binary
format or the newer
+ * NumericDocValues format for storing taxonomy faceting ordinals (for the
specified field).
+ *
+ * @deprecated Please do not rely on this method. It is added as a temporary
measure for providing
+ * index backwards-compatibility with Lucene 8 and earlier indexes, and
will be removed in
+ * Lucene 10.
+ */
+ @Deprecated
+ public static boolean usesOlderBinaryOrdinals(LeafReader reader, String
field) {
+ FieldInfo fieldInfo = reader.getFieldInfos().fieldInfo(field);
+ return fieldInfo != null && DocValuesType.BINARY ==
fieldInfo.getDocValuesType();
Review comment:
Got so caught up in trying to explain why there are two PRs I didn't
reply to this actual comment. Yes, I think that makes sense. Thanks to both of
you for the suggestion. I'll update this in the next revision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
