dsmiley commented on pull request #412: URL: https://github.com/apache/lucene/pull/412#issuecomment-953329902
> Does the new builder class look right to you? Is it expected to remove all setters from this class? This would mean I'll have to modify all their references in other classes and unit tests and replace them with builders. It looks good at a glance... you/I will see better if you update one of the clients that might want to subclass with extra configuration. Is there any or is this builder subclassing issue entirely hypothetical at this point? I suspect only hypothetical. We'll want nice Javadocs on the builder setters since this is where consumers/clients will see it. We can merely move the docs there from the existing locations, and add javadoc references pointing to the builder from the existing fields/enum values as desired. > This would mean I'll have to modify all their references in other classes and unit tests and replace them with builders. Yes, that's the point of this issue. You might try updating just one/two source files (presumably tests) and see how it goes. If there's some ugliness that brings doubt then maybe stop and share, otherwise continue. RE 9.0. If this doesn't make 9.0, then the actual removal of the setters would happen in 10 but the rest of it (the builder) could arrive in 9.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
