[
https://issues.apache.org/jira/browse/LUCENE-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433366#comment-17433366
]
David Smiley commented on LUCENE-10197:
---------------------------------------
Development wouldn't be halted but it wouldn't be "released" until Lucene 10,
likely in 2023.
Are you opposed to the GitHub PR process? I find it superior for collaborative
development than old patch files.
I took a brief look at your patch. The builder itself looks nice but I think
overall it misses the point because build() calls a bunch of setters on
UnifiedHighlighter. A key outcome here is for UH to be immutable. The
constructor for the UH could take this builder and populate itself accordingly.
Remember we need to support UH subclassing too.
> UnifiedHighlighter should use builders for thread-safety
> --------------------------------------------------------
>
> Key: LUCENE-10197
> URL: https://issues.apache.org/jira/browse/LUCENE-10197
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/highlighter
> Reporter: Animesh Pandey
> Priority: Minor
> Labels: newdev
> Attachments: LUCENE-10197.patch
>
>
> UnifiedHighlighter is not thread-safe due to the presence of setters. We can
> move the fields to builder so that the class becomes thread-safe.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
