rmuir commented on pull request #389: URL: https://github.com/apache/lucene/pull/389#issuecomment-945322135
Hmm, sorry if I'm being overly nitpicky, but it doesn't seem good to mix this concern into `DirectWriter`? It has nothing to do with `DirectWriter`. Seems like writing the extra `0` should be instead done in `Lucene90DocValuesConsumer`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
