[
https://issues.apache.org/jira/browse/LUCENE-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429060#comment-17429060
]
Jan Høydahl commented on LUCENE-10173:
--------------------------------------
Great work hoss. Happy if you like to review the PR for LUCENE-10174, which now
hopefully does the right thing when kicking off the {{gradlew assembleRelease
mavenToLocal ..}} command.
> remove "--max-workers 1" restriction when using external GPG w/gradle build
> ---------------------------------------------------------------------------
>
> Key: LUCENE-10173
> URL: https://issues.apache.org/jira/browse/LUCENE-10173
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Chris M. Hostetter
> Assignee: Chris M. Hostetter
> Priority: Major
> Fix For: main (9.0)
>
> Attachments: LUCENE-10173.patch
>
>
> LUCENE-9488 amended the existing support for using gradle's signing plugin
> with external GPG process to sign files, by adding support for the signing
> plugin's java-implementation, and switching to the pure-java implementation
> by default.
> In the process dawid missunderstood some of documented issues that can pop up
> when using an external GPG process, and thought that using an external GPG
> process could _only_ work when using {{--max-workers 1}}.
> As a result, when changing the build so that using an external GPG process
> was _optional_ via 'useGpg' he added an explicit check to fail the build if
> this option is used w/o {{--max-workers 1}}.
> This issue is to:
> * revert that restriction when 'useGpg' is specified since it isn't
> necessary (nor as it turns out, does it actually help)
> * add a new restriction when 'useGpg' is specified to fail fast if the
> required keyName isn't provided (this was handled in a differnet way prior to
> LUCENE-9488, but that logic was removed when 'useGpg' became optional – we
> should add it back if and only if 'useGpg' is specified to prevent a very
> confusing and missleading error message that can occur otherwise)
> * improve the associated docs
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
